Update Azure Notification Hubs SDK for 100% swagger coverage#4313
Merged
dsgouda merged 21 commits intoAzure:psSdkJson6from May 16, 2018
Merged
Update Azure Notification Hubs SDK for 100% swagger coverage#4313dsgouda merged 21 commits intoAzure:psSdkJson6from
dsgouda merged 21 commits intoAzure:psSdkJson6from
Conversation
Contributor
Author
dsgouda
suggested changes
May 11, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
- Please generate the code using generate.ps1 similar to one here and commit all artifacts generated
- Run
msbuild build.proj /t:Build /p:Scope=SDKs\NotificationHubsand commit all files generated/modified - There are breaking changes introduced here, if a package has already been published, please bump the package id
dsgouda
suggested changes
May 14, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please run msbguild build.proj /t:build /p:Scope=SDKs\NotificationHubs and commit changes to the .props file
dsgouda
suggested changes
May 14, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Apologize for the turnaround, there are breaking changes being introduced into the sdk here. Please update the package version in csproj and AssemblyInfo files and this should be good to go.
dsgouda
approved these changes
May 16, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to CIs passing
@aimankhan thanks for addressing feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
Updating swagger for Notification Hubs to add examples azure-rest-api-specs#3034
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.